refactor: Repository.move filters nodes instead of deleting their sha#355
refactor: Repository.move filters nodes instead of deleting their sha#355AurelioDeRosa wants to merge 1 commit intomasterfrom
Conversation
|
@clayreimann do you know why the build keeps failing? |
|
They need better isolation. The tests are pretty fragile, if you look at the build logs for each build that fails they all fail in different ways. Perhaps we just need to slow them down further (maybe 300-400ms between calls), but I think the thing we can do for the tests is to make sure that each test can run independently–so remove cross-test dependencies–and set mocha to retry failed tests a couple times. I've often found that running a build a second time will result in the build passing. Also, we should update |
| return ref; | ||
| }); | ||
| }) | ||
| .filter((ref) => ref.type !== 'tree'); |
There was a problem hiding this comment.
Perhaps add whitespace for clarity.
There was a problem hiding this comment.
Sure. Where do you want to place it?
There was a problem hiding this comment.
between this line and the return
closes #215